Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add see more items component #910

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Jan 10, 2025

Related

Context

fix #445 and #894
See example with https://stageportal.lirmm.fr/ontologies/AGROVOC?p=classes

Before

image

After

Screencast.From.2025-01-10.11-30-13.webm

Changes

  • Add list items component to hide container items if more than max items (51b0afa)

  • Use list item component in concept details component for synonyms and others (db67ff3)

@Bilelkihal
Copy link
Collaborator

@syphax-bouazzouni, can you add a screenshot or something?
also the tests are not working

@syphax-bouazzouni
Copy link
Collaborator Author

@syphax-bouazzouni, can you add a screenshot or something? also the tests are not working

@Bilelkihal added the examples and finished this PR ready to review.

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/add-see-more-items-component branch from 59cb4bc to 3cdc9fe Compare January 11, 2025 17:29
@Bilelkihal Bilelkihal changed the base branch from master to development January 17, 2025 12:00
@Bilelkihal Bilelkihal merged commit 2d48fa4 into development Jan 17, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In concept details, hide to long rows that have more than 2 lines
2 participants